TakaroArchive

Channels

View FAQ

dev

textPage 10 of 208
« PreviousNext »
50 messages on this page
Sunday, April 3, 2022
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Honestly, anything you run across where you think "this would be better suited as a helper" is game
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
I'll look into adding the import/export feature to hooks next. Just gotta finish coding a system for a server I play on.
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
Most of my experience is in C#, but I'm able to learn new languages really quickly.
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
Never touched Javascript before and I made that command in like 20 mins lol.
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
List any helpers you want and I'll add them.
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
Ok all good.
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
whatever data I copied, I likely did it at that time :)
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Playground uses static data
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
When I use 
date
in the playground it says it's 
2019-03-16
.
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
What is up with this:
unknown.png

unknown.png

PNG • 4.1 KB

Download
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
Yeah, completely forgot about that, literally looked at that page for working out the command lol.
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
It supports a few different ways of passing the date
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/parse#date_time_string_format
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
No content
unknown.png

unknown.png

PNG • 13.9 KB

Download
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Javascripts 
Date
encompasses date and time at once :)
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
Doesn't include the time.
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
It only uses the date.
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Doesn't your datePassed helper already do that?
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
Time string being 
YYYY-MM-DDTHH:MM:SS
.
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
What should I call a helper for checking a time string to see if it is in the past?
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
All good man.
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
Will work on some more helpers and tests.
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Thanks ^^
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
So I'll be merging once the CI passes again
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Other than that, looks all good
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Added another commit which adds some automated tests :)
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
Ok all good.
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
You can't, it's an error because Docker credentials don't get passed to your branch
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
How do I fix this?
unknown.png

unknown.png

PNG • 4.5 KB

Download
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Thanks, I'll take a look in a bit 😄
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
Nice just made my first pull request lol.
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
but the branch where you make the changes doesnt matter I think
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Your PR should target the develop branch
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
Aight, what branch should I make the changes on?
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Aimed at the docs, but the principle is the same :p
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
This is some info on making PRs
https://docs.csmm.app/en/contributing.html
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
Just created the fork.
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Then, make your changes on a branch there and then make a PR to the main repo
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
No content
unknown.png

unknown.png

PNG • 21.0 KB

Download
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
You can do that top right of the repo
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
In order to do that, first make a fork of the main repo
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
So to submit your changes, you'll have to make a PR since you don't have rights to push to the main repo
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Awesome!
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
Getting github setup now.
Avatar for 8824204d34fee76f1f051c762fb24388fc6c1d4a38e0210fd1a6c9e5a0c1572e
User 882420
Just made a helper for seeing if a date has passed:
Handlebars.registerHelper('datePassed', function (date) {
return ((Date.now() - Date.parse(date)) >= 0);
});
Usage:
code to execute
{{/if}}```
Examples:
```{{#if (datePassed date)}}
say "This date has passed!"
{{/if}}```
Friday, February 25, 2022
Avatar for 6ceaf41ff27d04ff247f59c1bc5a9f4cc4ace95acc526862d52cdbbb8702989b
User 6ceaf4
Even better
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Haven't tested that :P But I imagine it works the same as other nested helpers, you'd use 
../index
to access the outer scope
Avatar for 6ceaf41ff27d04ff247f59c1bc5a9f4cc4ace95acc526862d52cdbbb8702989b
User 6ceaf4
Just making sure nothing gets broken. Other than that, many thanks
Avatar for 6ceaf41ff27d04ff247f59c1bc5a9f4cc4ace95acc526862d52cdbbb8702989b
User 6ceaf4
{{times}} inside a {{each}} using {{index}} and the other way around won't make any conflict with the internal index since this last one uses a @, right?
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Going live in a few minutes 😄
Avatar for a506fee3140c1a9cb5f83c4671951bd488e90ca6dc0482bf1cbc5478a2f8fa6e
User a506fe
https://tenor.com/view/wow-ok-gif-9997032