dev

textPage 22 of 208
50 messages on this page
Tuesday, October 5, 2021
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
These files are the base of any page, the other views get loaded inside those
Avatar for 0719815d16e00808bfccc97bbc5fe4f95cd99ea5b79afd90b4b27bcc3fdbedeb
User 071981
@User 22055452 how does the lazyloading work in sejs? where do i have to include the lib for aggrid?
Avatar for 0719815d16e00808bfccc97bbc5fe4f95cd99ea5b79afd90b4b27bcc3fdbedeb
User 071981
ah ok, the probs getting passed to window.SAILS_LOCALS right?
Avatar for 0719815d16e00808bfccc97bbc5fe4f95cd99ea5b79afd90b4b27bcc3fdbedeb
User 071981
ez clap ๐Ÿ˜„ i already build like 100 Tables with it. i will encapsulat it in an component so we can use it for the dashboard and playersoverview. the dashboard will apply an "online" filter on it. but i will need to figure out how to implement it with sails. I normally work with angular :D. Are there some kind of Component Classes or View Helpers in SailsJS? ๐Ÿ˜„
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Haha sounds good :p
Avatar for 374c5d8a234dd3a84b2e7712113bccfc34abaf33083b895e688b9899a24261ca
User 374c5d
i'll "remind" you every few months lol
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
The demo looks amazing, I hope you can do the same with the CSMM data :D
Avatar for 374c5d8a234dd3a84b2e7712113bccfc34abaf33083b895e688b9899a24261ca
User 374c5d
ok
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
It's still on the radar, dont worry ๐Ÿ˜‰
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Database migrations needed, backend fixes for the API, frontend changes to display groups, backend changes to make sure
$claim
works properly with it
Avatar for 374c5d8a234dd3a84b2e7712113bccfc34abaf33083b895e688b9899a24261ca
User 374c5d
ah ok
Avatar for 0719815d16e00808bfccc97bbc5fe4f95cd99ea5b79afd90b4b27bcc3fdbedeb
User 071981
would build it serverside as it is actually
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
It's in the issues, but I haven't labeled it for hacktoberfest since it'll require a bunch of changes
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
It's likely one of the most used paged on CSMM by admins
Avatar for 374c5d8a234dd3a84b2e7712113bccfc34abaf33083b895e688b9899a24261ca
User 374c5d
Cata, what about adding in for a shop category system or at least the ability to create a group of items?
Avatar for 0719815d16e00808bfccc97bbc5fe4f95cd99ea5b79afd90b4b27bcc3fdbedeb
User 071981
its the most powerfull datagrid i know, you can nearly do everything you can do with excel ๐Ÿ˜„
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
I'm 100% down to revamp the players page
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
All of that sounds great :D The homepage of the lib looks good too
Avatar for 0719815d16e00808bfccc97bbc5fe4f95cd99ea5b79afd90b4b27bcc3fdbedeb
User 071981
maybe rebuild the players overview with https://www.ag-grid.com/ ? ๐Ÿ˜„ i would love to have functionality like grouping by country and stuff like that in the player overview. i could also add action buttons to it. we could also use it for the dashboard and add an actionbutton dropdown for player action to it(https://github.com/CatalysmsServerManager/7-days-to-die-server-manager/issues/883)
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
But any open issue is a candidate :)
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
These are ones I've labeled for Hacktoberfest, they're all relatively easy and I've added comments to them with some extra info
https://github.com/CatalysmsServerManager/7-days-to-die-server-manager/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Ahacktoberfest
Avatar for 374c5d8a234dd3a84b2e7712113bccfc34abaf33083b895e688b9899a24261ca
User 374c5d
Cata, what tasks do you have up for Hacktoberfest?
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
If you want to do some more, I'll gladly point you in the right direction when needed ^^
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Thanks for your contribution โค๏ธ
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Sweet, I'm merging in a bit
Avatar for 0719815d16e00808bfccc97bbc5fe4f95cd99ea5b79afd90b4b27bcc3fdbedeb
User 071981
yea i already linked my account ๐Ÿ™‚
Avatar for 0719815d16e00808bfccc97bbc5fe4f95cd99ea5b79afd90b4b27bcc3fdbedeb
User 071981
fixed it ๐Ÿ˜„
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Did you sign up for hacktoberfest? This PR will count for it if you have your account linked and stuff
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
If you fix that, I'll happily merge ;D
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
It's great! Just one small issue with it (see comment)
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Sweet! I'll take a look :D
Avatar for 0719815d16e00808bfccc97bbc5fe4f95cd99ea5b79afd90b4b27bcc3fdbedeb
User 071981
ah ok
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
GH has a good article on this, lemme see if I can find it
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Oh you'll need to make a fork first, then do the change on there and then send a PR
Avatar for 0719815d16e00808bfccc97bbc5fe4f95cd99ea5b79afd90b4b27bcc3fdbedeb
User 071981
@User 22055452 I think i need permissions to push my branch? ๐Ÿ˜…
Avatar for 0719815d16e00808bfccc97bbc5fe4f95cd99ea5b79afd90b4b27bcc3fdbedeb
User 071981
ah lol ok you where right i can just delete the sort attribute because its only needed when a object get passed <:facepalm:364780978067210241>
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
dammit :p
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Oh right, because of the render prop probably
Avatar for 0719815d16e00808bfccc97bbc5fe4f95cd99ea5b79afd90b4b27bcc3fdbedeb
User 071981
then the sort does not get applied, does the datagrid got some kind of valueGetter function which can be applied? then i would wrap it into an object
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
It should default to sorting the actual prop value
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
Try deleting the line with sort: ?
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
ohh yes! That's probably it
Avatar for 0719815d16e00808bfccc97bbc5fe4f95cd99ea5b79afd90b4b27bcc3fdbedeb
User 071981
yea lemme try, normally i work with gitlab ^^
Avatar for 0719815d16e00808bfccc97bbc5fe4f95cd99ea5b79afd90b4b27bcc3fdbedeb
User 071981
i think the datagrid is expecting the Sort attribute to be in an Object. like at the role role.level. i think he is searching for name.name ๐Ÿ˜„
Avatar for bddf696212701f4e2e40cc177bb39c1f9c5f0a4ce49c307b79e8101c2a98158e
User bddf69
If you make a PR, I can take a closer look if you want