dev

Will the new workflow that’s added with the PR be an issue?

done 😄

or wait. wtf

it fcked itself up. I'll open another PR instead 😄

Yeah give that a try ^^ Or maybe rebase your changes ontop of the upstream branch? Idk what the better approach is

it might be conflicting because it was prior to the current release. Shall I merge upstream?

I think so yeah but not 100% sure

is it master?

Sorry to be a pain :( Merge conflicts.. I thnik it's cause your base branch is master while the PR should be pointer to the development branch

Longtext and text('long') are almost the same. lmao

yap. xd

No rush :D

Thanks for the improvement. 😄 as soon as I’m near my pc

I was going to look at the chatbridge PR but it looks like the tests are failing for that one, would you mind taking a look at that please? ❤️
https://github.com/CatalysmsServerManager/7-days-to-die-server-manager/runs/4459956621?check_suite_focus=true

@User 32669748 Reviewed and merging the items PR in a few minutes. Thanks again :D I made a small edit to your code to filter out empty strings too and added a test :)

Prevent regressions like this in the future.. 😄

Looks good, but I'll add a test for this tonight

I've edited the PR to target the development branch instead of master

Awesome, many thanks!

4544e22

😛

Yeh, here is the magic
https://github.com/niekcandaele/machinepack-7Days-webapi/blob/master/machines/list-items.js#L113

Or you can make a PR if you feel like it ;p

I can fix it tonight

Here, will probably need to do something like

response.split('\n')

I suspect that this will be the cause

The old one did some magic while the new one is more raw

Oh yes it probably did, I switched from an old library to a newer one

@User 22055452
did the availableItems response change?

/api/sdtdserver/availableitems?serverId=1&item=*

It gives back unsanitized results, and the item name "suggestion" will never complete.

Maybe this?

I don’t mind giving a helping handy tho

Same here 🤣

Haha your CPM dev role still takes priority over the code contributer one :p So no change for you really

i was so kidding

you didnt

nooooooooo

Wohow. Feeling special now

but you already have an ultra-special colour 😂

Haha for sure

😄

can i has color?

i read some of your code

once at flute camp....

Thanks 😄

Thank you so much. it's 🔥

@User 70801558 @User 32669748 @User 18840696 @User 15225025

I've added a new role on Discord: Code contributor. Enjoy your new colour :D And thank you all for your contributions ❤️

And if I forgot anyone who's comitted code in the past, please give me a poke and you'll get the role too ^^

Hmm I have an old db I could send over lmao

It should be working. No aorries, take your time ^^.

Soooo tired of coding right now 😄

Looks nice! Just one question: will the migrations work properly both when you set up the database from scratch and for people who update now?

I will have to test your PR a little more but I wont get around to it tonight anymore