dev

Sweet, I'll check it out in a little bit 😄

@User 22055452 commited the requested file. I hope lmao 😉

Awesome, thanks for debugging! :P

it went through. Will create a PR that adds python3

wird that it takes so long, its on a NAND SSD

changed ownership of '/usr/src/app/node_modules/@sentry/core/esm/version.js.map' to 1000:1000

low it logs like crazy, lets see if it stops

alright, thx

Lunch break almost over so my replies are going to be delayed now.. :P

You can view versions and log output and all on the CI job I linked above if you wanna compare those

Sounds good!

ill make it verbose and see

good, what i expected

Should atleast :p

Nah, the Docker build does everything

do i need build CSMM on my machine before buliding docker? didnt even install npm deps yet

npm ci is passing with

python3 (3.8.10-r0)

installed via apk

still stuck at chown 😄

i am building straight on my server

server is on debian

actually no

🤐

hihi

I never tested on M1/M2 devices tbh

What machine are you building on? If you're on a ARM mac or something, that might cause some trouble

ill add python3 and see

That one took 0.6 seconds in CI, so yeah shouldnt get stuck there
https://github.com/CatalysmsServerManager/7-days-to-die-server-manager/runs/4423448355?check_suite_focus=true#step:12:503

also had to remove the fixed versions in the apk install command, it said it couldnt find it (and then installed exact that version 🤷 )

RUN apk --no-cache add curl=7.79.1-r0 git jq

it doesnt and hangs at step 15 which should take seconds i guess:

Step 15/19 : RUN chown -R node:node /usr/src/app

It shouldnt stop the build though?

Hmm good catch, I see the same issue in CI

Hey. Trying to get docker + development branch running.

Is it normal that python is missing // snappy install kinda fails on docker build?

prebuild-install WARN install No prebuilt binaries found (target=14.18.1 runtime=node arch=x64 libc=musl platform=linux)
gyp ERR! find Python
gyp ERR! find Python Python is not set from command line or npm configuration
gyp ERR! find Python Python is not set from environment variable PYTHON
gyp ERR! find Python checking if "python" can be used
gyp ERR! find Python - "python" is not in PATH or produced an error
gyp ERR! find Python checking if "python2" can be used
gyp ERR! find Python - "python2" is not in PATH or produced an error
gyp ERR! find Python checking if "python3" can be used
gyp ERR! find Python - "python3" is not in PATH or produced an error
gyp ERR! find Python

Renovate :3 tests :3

True that, can get very boring 😄

I have dependabot for it but validating the update doesnt break anything is time consuming and boring

There's a bunch of tests but they were added after the code mostly

Iffy :p

How confident are you about your tests? I use https://renovatebot.com/ to keep my dependencies up2date

Winston is amazing ^^

The passport implementation is ok, I'm sure it could be better

Quite a few of the deps will be outdated, stuff moves too fast

nice to see winston in a real project, also looking forward to your passport implementation. Always wanted to use it but never found time

Small thingy: The lock file is outdated.

Merging to master now, main instances will be updated soon after

Tested, seems all good!

I'll test there tonight and merge to master

If anyone is reading this and wants to test it out on staging, please do

Merging to dev! Thanks :D

@User 22055452 https://github.com/CatalysmsServerManager/7-days-to-die-server-manager/pull/934/files

alright, will add that test during next week, im not home until Tuesday 😄

Let me know if you need any guidance for writing the tests :P

@User 70801558 re: https://github.com/CatalysmsServerManager/7-days-to-die-server-manager/pull/927

Looks great! I'm really excited for this, will make player management muuuch better 😄

Only thing I'd like to see on that PR is to add some tests for the API endpoint. The CI isn't reporting it in the Github comments for some reason, but coverage went down, https://codecov.io/github/CatalysmsServerManager/7-days-to-die-server-manager/commit/cbb6c40b96bb047fff3368eb958733bb85ca6923

See https://github.com/CatalysmsServerManager/7-days-to-die-server-manager/blob/master/test/integration/controllers/savedTeleports.test.js for an example of a test that's similar